Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(orgs): Add section for invalid states #1676

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Nov 4, 2024

Explanation:

This PR:

Resolves ORGS-284

Adds a section to clarify regarding organization invalid states. This could be linked to our upcoming Dashboard changes (https://github.com/clerk/dashboard/pull/3917)

Copy link

github-actions bot commented Nov 4, 2024

Hey, here’s your docs preview: https://clerk.com/docs/pr/1676

@LauraBeatris LauraBeatris marked this pull request as ready for review November 22, 2024 17:15
@LauraBeatris LauraBeatris requested a review from a team as a code owner November 22, 2024 17:16
@LauraBeatris LauraBeatris force-pushed the organization-invalid-states branch from ce23ba9 to eb2fa9d Compare November 22, 2024 17:16

## Invalid states

Organizations can enter invalid states under certain conditions. Here are the common scenarios you should be aware of:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Organizations can enter invalid states under certain conditions. Here are the common scenarios you should be aware of:
Organizations can enter invalid states under certain conditions.

we can either fully omit a second sentence, or have it like this:

Suggested change
Organizations can enter invalid states under certain conditions. Here are the common scenarios you should be aware of:
Organizations can enter invalid states under certain conditions. See the following sections for more information.

I prefer the first.


### Missing member with elevated permissions

An organization becomes invalid when it has no members with the following elevated permissions: `org:sys_memberships:read`, `org:sys_memberships:manage`, and `org:sys_profile:delete`. This typically occurs when removing the last admin or downgrading their role.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit for readability.

Suggested change
An organization becomes invalid when it has no members with the following elevated permissions: `org:sys_memberships:read`, `org:sys_memberships:manage`, and `org:sys_profile:delete`. This typically occurs when removing the last admin or downgrading their role.
An organization becomes invalid when it has no members with the following elevated permissions: `org:sys_memberships:read`, `org:sys_memberships:manage`, and `org:sys_profile:delete`. This typically occurs when the last admin is removed or their role is downgraded.

@LauraBeatris LauraBeatris marked this pull request as draft December 2, 2024 17:29
@LauraBeatris
Copy link
Member Author

LauraBeatris commented Dec 2, 2024

@victoriaxyz @alexisintech Sorry for turning this into a draft again. I just want to make sure it isn't going to be merged just yet.

This feature is behind a feature flag for testing in staging only, will be publishing the docs once it lands in production. I'll keep you updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants